iPhone UILabel not updating

Discussion in 'iPhone/iPad Programming' started by jk7, Mar 30, 2008.

  1. jk7, Mar 30, 2008
    Last edited by a moderator: Nov 11, 2010

    jk7
    macrumors newbie

    Joined:
    Mar 30, 2008
    #1
    I'm writing an app for the iPhone and I'm finding that the UILabel is not updating. A worker thread updates a string and calls a method on the view that changes the text in a UILabel subview.

    I'm not seeing the new values appear in the UILabel.

    Here's the code for the view, the updateDisplay method is called by the worker thread.

    Anybody know why the UILabel doesn't get updated?

    I attached the whole project.

    Thx

    Code:
    #import "MyView.h"
    
    @implementation MyView
    
    @synthesize label;
    
    -(id)initWithFrame:(CGRect)aRect
    {
       if (![super initWithFrame:aRect]) return nil;
       
       self.backgroundColor = [UIColor whiteColor];
    
       CGRect labelFrame = CGRectInset(aRect, 90, 90);
       
       self.label = [[UILabel alloc] initWithFrame:labelFrame];
       self.label.contentMode = UIViewContentModeRedraw;
       [self addSubview: self.label];
       [self bringSubviewToFront:self.label];
       self.label.text = @"initial value";
    
       return self;
    }
    
    -(void) updateDisplay:(NSString *)str
    {
       self.label.text = str;
       [self.label setNeedsDisplay];
       //[self setNeedsDisplay];
       //[self.window setNeedsDisplay];
    }
    @end
     

    Attached Files:

    • foo.zip
      File size:
      14.8 KB
      Views:
      285
  2. jk7, Mar 31, 2008
    Last edited by a moderator: May 9, 2011

    jk7
    thread starter macrumors newbie

    Joined:
    Mar 30, 2008
    #2
    I added a setNeedsDisplay after I noticed that the UILabel was not updating.

    Also if anybody runs that project be sure to exit the application by pressing the home button.

    I've crashed my mbp a number of times debugging that project and think it might be runaway threads.
     
  3. therevolution, Apr 3, 2008
    Last edited by a moderator: May 9, 2011

    macrumors 6502

    Joined:
    May 12, 2003
    #3
    I am actually having a similar problem with cells in a UITableView. Updating a UILabel might be similar. Did you get it resolved, or does anyone else know the trick to updating the UI?

    It'll update the contents if I touch the screen, but not if it's left alone. I've tried several variations of [table reloadData], [table setNeedsLayout], [table setNeedsDisplay], doing the same to each of the cells... no luck so far.
     
  4. jk7, Apr 3, 2008
    Last edited by a moderator: May 9, 2011

    jk7
    thread starter macrumors newbie

    Joined:
    Mar 30, 2008
    #4
    reply was deleted

    This code is working for me in the above project, currently having problems crashing mbp so wouldn't recomend running the project attached to this thread

    Code:
    -(void) updateDisplay : ( NSString *)str
    {
       [self.label performSelectorOnMainThread : @ selector(setText : ) withObject:str waitUntilDone:YES];
    }
     
  5. macrumors 6502

    Joined:
    May 12, 2003
    #5
    Awesome, thanks. That did it. You get a gold star.
     
  6. macrumors 68030

    jared_kipe

    Joined:
    Dec 8, 2003
    Location:
    Seattle
    #6
    You shouldn't need to call self.label.text, since label is an ivar of your own class.

    label.text = str;

    SHOULD be fine. I've never created a view like this programatically, I always use xib files and then move or change properties as I need to. I wouldn't think this would change how the UIView subclasses like UILabel or UIImageView redraw themselves when changed.

    It will not redraw until the method that makes the change returns though.
    I use similar methods to update the main view after changing triangles in the Right Triangle Tutor app I have on the store currently.
     
  7. Bagnaria, Nov 10, 2010
    Last edited by a moderator: Nov 11, 2010

    macrumors newbie

    Joined:
    Nov 10, 2010
    #7
    Contents of Nib files are not always available

    One thing to be aware of with iPhone applications is that one can not rely on UI elements that where initialized from a nib file. The reason is that Cocoa Touch tries to save as much memory as possible and only instantiates the UI elements of a nib file when they are visible. Then it tosses them only to re-instantiate them should the interface become visible again. So while the "Your"-ViewController class is instantiated you can not rely on the IBOutlets to be there. An easy check in the Debugger is that the label (or other UI element) will be null/nil. This has a lot to do with timing so what works in one place may not work in another. Which why this is so hard to catch.

    The solution:
    While the IBOutlets may not always be instantiated, all other instance variables will be persistent. So in this example I would simply add an NSString ivar, let's call it "labelString". The "labelString" can be set as soon as your controller has been initialized (or right then). When it is showtime the viewDidLoad method will be called. It should look similar to this like this:

    Code:
     - (void)viewDidLoad {
        uiLabel.text = labelString; // set the label when it is actually shown
    
        [super viewDidLoad];
    }
    
    Hope this helps. It is a behaviour that can be very frustrating, but once you are aware of it you will be much happier.
     

Share This Page