Solution that worked for me...
I have a friend who has had this problem since upgrading to Lion on a Macbook (with a Broadcom chipset) and this is what I did to resolve it for her.
Not guaranteeing this works for everyone, but it worked for us...
1. Open KeyChain scripting app (in Applications/Utilities) and delete any entries related to wifi connections.
2. Open Network Preferences and delete all existing WiFi connections completely.
3. Shutdown the Mac.
4. Power on while holding Command, Option/Alt, P and R keys (PRAM reset). Wait until you have heard 3 restart sounds then let go of the keys and let the Mac boot up.
5. After booting, set-up your WiFi connection again (you may have to re-enter the password so make sure you have it).
After doing the above 5 steps my friends Macbook now connects perfectly to the wireless every time... I am convinced there was some kind of corruption occurred in the keychain scripting app during the Lion upgrade, but I'm not an expert so will never really know...
Hope this helps. If it doesn't, my apologies, but at least you had something to try and eliminate in your troubleshooting steps.
Regards.
Floridabrits