I agree that the current crop of Apple notebooks are problematic. The lineup is cluttered and confusing for non-techy folks, the keyboard fiasco is a massive black eye, an unforced error that they just keep compounding. The non-Touch Bar notebooks are 2 CPU generations behind for no obvious reason. Have they been abandoned? Who knows! And so on.
They offer expensive CPU "upgrades" in their notebooks that actually run slower in many key scenarios than the CPU you're "upgrading" from because, well, the laws of physics are annoyingly immutable.
Plus, Apple is price gouging like crazy on RAM and SSDs, both of which are dirt cheap now. You can get 16GB of RAM for a hundred bucks. You can get a 1TB PCIE SSD with passable performance (Intel 660p) for $100, or one with excellent performance for twice that. But despite the prices of both RAM and SSD's bottoming out over the last several months, Apple continues to charge the same premium as when component prices were 2X or more higher than they are now. But, hey, if you want more RAM or storage in your MacBook, you have to buy it from Apple or else, so they can charge what they please ...
They're still shipping desktop computers with 8GB of RAM and 5400RPM spinning disks that can't be upgraded. If I were them, I'd be plain embarrassed to ask people to buy that crap in 2019.
They've been designing the new "modular" Mac Pro for years now, which tells me conclusively that what they end up releasing won't be what I and many other want, because it wouldn't take years to update the cheese grater case to modern specs.
But, at the end of the day the PC OEMs really aren't any better in many ways, and in a lot of ways they are worse. For whatever reason, Apple gets publicly brutalized for each and every little problem while other companies release one piece of broken junk after another, leave their customers hanging, and move on to repeat the cycle without much noise and fuss. If you buy a flawed Apple machine, odds are they'll be forced to make it right at some point, one way or another. If you buy a flawed PC there's a very good chance you're just screwed.