Help me out

Discussion in 'Web Design and Development' started by jtalerico, Feb 18, 2006.

  1. macrumors 6502

    Nov 23, 2005
  2. macrumors 6502


    Dec 15, 2005
    Sweden - Halmstad
    Start off by using a doctype so the webb browsers know what kind of document it should render.

    And try to clean up your code, it looks very messy.

    Practicly all your code is wrong.

    Example: you write like this: <img src=images/banner/1.jpg width=100%>

    when it should be: <img src="images/banner/1.jpg">

    And you have a starting <center> tag but you do not have a closing one: </center>

    And your color tags is wrong to, you have this: <td bgcolor=6D7B8D>

    When it should look like this <td bgcolor="#6D7B8D">

    It is impossible to help you when everything is wrong, fix all this first and come back with your problem when you are done.
  3. macrumors 68030


    Nov 7, 2003
    he is generating the code in php, so i'd say the messy part is a bit forgivable. It is hard for newbies in php to format html code right off the bat. However, you are his html skills are awful, but seems to have manage to get php working. Although, there isn't really anything dynamic so, technically he could have just had html in a php file. he needs to work on the his image optimization on thumbnails.
  4. thread starter macrumors 6502

    Nov 23, 2005

    Yup, I am doing all this in PHP.. Not really new at php just getting back into the swing of things...

    What is wrong with how the source looks?? :p It is hidious i know.. Maybe i will throw some \n in there so it looks a little bit better. About my consern, how do i get it to look at least decent in IE?
  5. macrumors 6502a

    mac 2005

    Apr 1, 2005
    What is the importance of using the quote marks? I use them on occasion but not all the time, and I don't seem to see an adverse affect. So that's why I'm asking....
  6. thread starter macrumors 6502

    Nov 23, 2005
    I would also like to note that taking off the image width just made the image look even worse. I fixed the problem with IE I removed the 100% and made it the same width as the table it is in, which is width=900... If you want, i made the HMTL look a little better by adding the \n so it is spaced out for your reading pleasure!
  7. macrumors 65816


    Aug 16, 2004
    That picture is huge.
  8. thread starter macrumors 6502

    Nov 23, 2005
    Should i make it smaller?
  9. macrumors 6502

    May 12, 2003
    From a file size perspective, at least, it's enormous. 250KB is way too much to be pushing to the user. It's wasteful to download a 1482x524 image only to force it down to 900x200 (not to mention it distorts the image - everything looks squished). If you want 900x200, crop the image to that size first.
  10. macrumors 6502


    Dec 15, 2005
    Sweden - Halmstad
    I did not tell you to remove the image width, i just showed you how it should look like to write in W3 standard.

    Now it basicly look the same in both browser so are you done or do you want help to do it exactly the same in both browsers?
  11. Guest

    Seeing you are using Firefox, do yourself a favour and download the HTML Validator and WebDeveloper

    The HTML Validator extension will instantly give you 19 very useful warnings about your page and the Tools->Validate HTML link in the WebDeveloper extension will give you even more ways to get your page looking good on all browsers!

Share This Page