Got 32gb Black iPhone 4 at the moment, not 100% sure i will upgrade, but if i did will prob be the same again. Black 32gb.
im not that far off filing this up, with videos, music and apps and games starting to get bigger. Also the extra mb's needed for the higher res photos and video of the 4S, prob means 32gb will be just bout right.
Oh also black, i did want white when iphone 4 was launched but was only black available so took that one, glad i did. yeah the white looks nice, but for me distracts from the screen as with the black, black borders are less noticeable when watching videos etc. Plus can always get different colour back anyhow off flea bay