I have had 256gb iPhones since iPhone XS Max, iPhone 11 Pro Max and iPhone 12 Pro
but I went with 128gb iPhone 13 pro max this time. I really don’t use more than 60-80gb. Max I think I ever got in any of my phones was 100gb
I’m currently using 50gb out of 256gb (205.8gb storage left). I have 140 apps and 2000 photos. Not many videos (18)
if you play a lot of games (some games consume 4-5gb these days) or shoot video. Than yes. Get more storage.
I also delete all my messages and restore my iPhone 2-3x a year. So that clears up a lot of junk.
I usually don’t keep my phones more than 1 year. So the trade in takes a hit going for more storage I don’t need.