I would think CPU performance would be the key factor in speeding up your video encoding. So if you can get a machine with lots of cores, that would be the thing to concentrate on probably. Might be worth checking out some benchmark sites if possible to try and get an idea of what's worth it over your macbook.
Speed and memory. You can compensate for the former with more of the later, but there is a sweet spot where everything works the best which depends on what you are doing, and how the program utilizes the resources available.
----------
The mini is a better option. The 2008 mac pro is an old machine, better to get something with a i-core processor.
If you can get a 2012 i7 mini for a good price is a really better option. Even a entry level imac (the one with the quad i5) is a very good option to.
Changing your macbook pro for a more recent model is a good upgrade, just stay away of the 2011 models.
The Mini is a dead end machine though. No upgrades, very closed. With a Mac Pro, even an old one, you can compensate for the age, plus the Xeon processor is built for throughput. Many people have been able to upgrade their older Mac Pros to faster processors. I've got an 8-core Xeon and its great for getting the work done. It's also an older 4,1. I can load up the drives and go to town working on video and sound all night Plus the memory isn't as severely limited as on the Mini.
----------
Are the newer i core processors much faster than the old ones then? I must admit I assumed say a 2.6 i5 dual core wouldn't be a great deal faster than a 2.4 C2D?
Here's where you have to be careful. Just because an i7 is newer does NOT mean that it's faster. Intel has been tweaking their processors and some higher speed processors are not performing at certain tasks better than older processors, and more cores does not mean faster processing either.
You have to look at the specs
for the task you are going to be doing and see how the particular processor performs
doing that task. But often, to be honest, you don't have much control over the processor you get. Meaning that you order one new, you *can* choose a different processor on nearly all models. Just be careful. I remember specs on an i5 that outperformed an i7 at certain tasks. It's not a given that the i7 will leave scorched Earth and rubber compared to an i5.
Don't dismiss an older Mac Pro either. You can stock it with drives up the butt, and dump a lot of memory into them, and they have the expansion capabilities, like I said above, and for a decent price, you get a box with potential. I do some video and audio on my older 4,1, and it works pretty well for what I do. I have it loaded with terabyte drives and gobs of memory, and sometimes it does have to crunch stuff overnight, but it gets it done.
I'd love a new Mac Pro, but realistically, it would be too fast, and too expensive, with the later being the stopping issue. I may upgrade the processors at some point and put new legs under it, but it works well.
----------
Currently I'm thinking a 27" iMac may be the better option (I was looking at some 2010's but might stretch to new).
I'm sure I read somewhere that VRAM was only really used for 3D rendering but Apple say "256MB of VRAM (1GB recommended for 4K)" in the system requirements.
So does VRAM make that much difference? I have no plans to do anything with 4K but if more VRAM will speed up FCP or Aperture then its something for me to consider
I don't think it will help you. It's more the GPU than the VRAM, and an iMac isn't going to have a good enough GPU to help that much, if at all from my understanding.
----------
In final cut, the upgrade to the i7 processor is more important than VRAM.
Get the entry 27" model, and upgrade the processor to i7. Get the ram from crucial or macsales.
I don't know if I tripped onto some hidden sale or what, but I ordered an iMac for pickup, and mentioned adding memory, and the 'Apple memory' they quoted was not much over the price of the memory (10 bucks a stick) I was going to buy when I got it home. I jumped on it there, and they installed it for free (not that it's that hard to install).
I had an iMac go mental a few years back from what *could have been* bad memory. It was from Kingston, and I had never had an issue with memory before, or system stability. I'd check at an Apple Store and see what they are expecting for memory...