just noticed that in finder under the file menu is a command to compress the folder. is there any reason not to use it? will it mess up my files? what kind of space savings can i expect? is it suitable for photo and video files?
It's useful only for files you don't use (often), as you cannot access the compressed files without uncompressing them. Essentially it just creates a zip file that contains compressed versions of the selected files.