macOS Error Expected ";" before "{" token

[aemti]

Can someone see where this code is wrong I can't see it but i've been staring at it for three hours! could it be in a different file? ie.) implementation files?

#import <UIKit/UIKit.h>
#import "CalculatorBrain.h"

@interface CalculatorViewController : UIViewController
{
	IBOutlet UILabel *display;
	CalculatorBrain *brain;
	BOOL userIsInTheMiddleOfTypingANumber;
}

- (IBAction)digitPressed:(UIButton *)sender
{    <---this is where the error expected";"before"{" token comes in--->
		
	if (userIsInTheMiddleOfTypingANumber) 
	{ 
		[display setText:[[display text] stringByAppendingString:digit]]
	} 
	else 
	{ 	
		[display setText:digit] 
		userIsInTheMiddleOfTypingANumber = YES 
	}
	NSString *digit = [[sender titleLabel] text]
	
}
- (IBAction)operationPressed:(UIButton *)sender
{
	if (userIsInTheMiddleOfTypingANumber)
	{ 
		[[self brain] setOperand:[[display text] doubleValue]] 
		userIsInTheMiddleOfTypingANumber = NO
	}
	NSString *operation = [[sender titleLabel] text]
	double result = [[self brain] performOperation:operation]
	[display setText:[NSString stringWithFormat:@"%g", result]]
}

@end

 

[ccamelot]

You're right

Sure, try to use *.m file as well.

In you *.h file:

#import <UIKit/UIKit.h>
#import "CalculatorBrain.h"

@interface CalculatorViewController : UIViewController
{
IBOutlet UILabel *display;
CalculatorBrain *brain;
BOOL userIsInTheMiddleOfTypingANumber;
}

- (IBAction)digitPressedUIButton: (id)sender;
- (IBAction)operationPressedUIButton: (id)sender;
@end

and then in *.m file put implementation

- (IBAction)digitPressedUIButton: (id)sender { 
if (userIsInTheMiddleOfTypingANumber) 
 ...

 

[Alkiera]

ccamelot is correct, it's because you're putting code inside the @interface.

If you want to put it in one file like that, you still need to define the interface separately from the implementation.

 

[aemti]

could you clarify which file?

I've tried both with no success. When you say *.m and *.h are you referring to the view controller files or the calculatorbrain.m and .h files? Thanks again!

 

[Ap0ks]

The code ccamelot posted needs to go in your CalculatorViewController.h file, then your method implementation goes in the CalculatorViewController.m file.

CalculatorViewController.h should look something like (as ccamelot posted):

#import <UIKit/UIKit.h>
#import "CalculatorBrain.h"

@interface CalculatorViewController : UIViewController
{
IBOutlet UILabel *display;
CalculatorBrain *brain;
BOOL userIsInTheMiddleOfTypingANumber;
}

- (IBAction)digitPressedUIButton: (id)sender;
- (IBAction)operationPressedUIButton: (id)sender;
@end

CalculatorViewController.m should look something like:

#import "CalculatorViewController.h"

@implementation CalculatorViewController

- (IBAction)digitPressed:(UIButton *)sender
{    <---this is where the error expected";"before"{" token comes in--->
		
	if (userIsInTheMiddleOfTypingANumber) 
	{ 
		[display setText:[[display text] stringByAppendingString:digit]]
	} 
	else 
	{ 	
		[display setText:digit] 
		userIsInTheMiddleOfTypingANumber = YES 
	}
	NSString *digit = [[sender titleLabel] text]
	
}
- (IBAction)operationPressed:(UIButton *)sender
{
	if (userIsInTheMiddleOfTypingANumber)
	{ 
		[[self brain] setOperand:[[display text] doubleValue]] 
		userIsInTheMiddleOfTypingANumber = NO
	}
	NSString *operation = [[sender titleLabel] text]
	double result = [[self brain] performOperation:operation]
	[display setText:[NSString stringWithFormat:@"%g", result]]
}

@end