Any idea why this happens, it seems like every day I get told my apple ID is locked and to reset it by email or security questions, its becoming a pain in the backside now.
Have all your devices been using the same Apple ID? If yes, do you have 2FA turned on? If not, consider doing that. It is possible someone has been trying to gain access to your account. It would also be a good idea to change your password.
Any idea why this happens, it seems like every day I get told my apple ID is locked and to reset it by email or security questions, its becoming a pain in the backside now.
Possibly, but at the same time many people are using 2FA either because they elected to or it got enabled for them essentially by default at some point. So that cuts down on those who might be affected. Out of those who aren't using 2FA it's possible this isn't something that's hitting all of...