256Gb is plenty for me.
I've had a 256 8+ for a year. I've currently got 184 Gb used up. This includes almost 80Gb of music and just under 60Gb of photos. Could I fill 512Gb? Sure, probably, I could download all my movies from the cloud but it's just an unnecessary cost. I love having music on the phone but I've recently paid for You Tube Premium and my music collection could do with a few albums being removed off the phone. Think the extra cost is just too much to justify. To be honest, I'm trying to justify upgrading to the Xs Max. Until o2 drop news of their prices, I'm in purgatory.