I have a 2018 2.3ghz (the one with four thunderbolt ports) 8gb 512gb of storage MacBook Pro. I took advantage of the keyboard replacement program not too long ago so I have the 2019 butterfly keyboard which I love and since I had the keyboard replaced they put in a brand new battery. This machine still flies so I am struggling to think of reasons why I need the new M1 apart from battery life and being newer. What do you all think? Did anyone upgrade from the 2018 MBP?
Is this a 13" or a 15"? Your post doesn't clearly define which.
Secondly, if losing two Thunderbolt ports isn't a big deal for you, and we're talking about a 2018 13" model, then I'd absolutely sell your 2018 model in favor of an M1 model. My reasons why are as follows:
1) Greater support longevity (There will come a time when the 2020 M1 2-port 13" MacBook Pros will be supported for a new macOS release and both 2020 Intel 13" MacBook Pro models won't.)
2) The performance really is THAT much better
3) Your keyboard will inevitably fail again (this wouldn't be a part of my recommendation to someone with a 2020 Intel model as those also don't have the butterfly keyboards)
4) Physical Escape Key (have you ever had to force quit an app that also crashed your TouchBar?)
5) The machine runs cooler and you will likely seldom (if ever) hear your fan rev, which is definitely unlike your 2018 model
6) And yes, as you've stated, battery.
Were it a normal upgrade cycle (that didn't involve moving from an inevitably failing keyboard design), I wouldn't advise you to upgrade so soon. However, the above warrants an exception.
I should also add that, while many are waiting for a redesign, the MacBook Pros have long had a history of the first one or two revs of a new redesign being the least reliable (and most prone to quality repair extension programs). This was true of the first Intel MacBook Pros, which had various heat issues caused by the ATI Radeon X1600 Mobility, as well as the second batch that had the dreaded NVIDIA GeForce 8600M GT. The first Unibody models also had issues, albeit the least out of any MacBook Pro design generation. The first 15" Retina MacBook Pros suffered from GPU issues, and the first TouchBar MacBook Pros suffered from a myriad of issues on top of the keyboards. The benefit of the 2020 M1 2-port 13" MacBook Pro is that most of the rest of the components are unchanged from its 2020 Intel 8th Generation ULV U-series equipped 2-port predecessor. Components like the keyboard, the display and other things are the same. The design of the logic board is even the same, even if the processor, RAM, storage, and underlying architecture is different.
A redesign changes all of that and usually isn't stable until the second or third rev. Certainly, a 2020 M1 2-port 13" MacBook Pro is still a massive upgrade over a 2018 4-port 13" MacBook Pro. But it's also a stable one.