Become a MacRumors Supporter for $50/year with no ads, ability to filter front page stories, and private forums.
Doesn’t your iPhone need to be charging and on WiFi and the same with the MacBook for that to work? Not sure but used to be something like that.
 
Are your photos being uploaded to iCloud?

On iPhone: Settings -> Apple ID -> iCloud -> Photos set to "on"
On MacBook: System Preferences -> Apple ID -> iCloud -> Photos checked

Sometimes, for some reason known only to Apple, my iPhone photos pause uploading to iCloud "to save battery." This happens even when the battery is fully charged. I have to go into the photo app, scroll to the bottom of the library tab, and tell it to resume. Once a photo gets to iCloud, it usually appears on my MacBook promptly.
 
Yeah, something changed. My iPhone photos used to upload automatically (with settings as recommended by JBinPDX). Now, preferring not to periodically hardwire my iPhone to my Mac, I just email my photos to myself, then move them from email to Photos on my Mac.
 
Register on MacRumors! This sidebar will go away, and you'll see fewer ads.