Well, if everything is going with your current iPhone and you are thinking to upgrade just because you are too tempted, then you shouldn't be bothered to upgrade
But having said that, it will be a significant upgrade as especially if you opt for 12 Pro and like photography on the phone.