I'm happily using a Samsung T5 2TB since a while now and can really recommend them. It's not the same speed as the new MBPs internal SSD (not sure if there are any external SSDs that approach similar speeds... the new MBPs are king in this regard), but for all intents and purposes they are some capable, speedy drives with a much better $/€-per-Gigabyte ratio than choosing the 2TB internal drive over the 1TB (the 2TB upgrade from 1TB for the MBPs is about 900€, I got my T5 for 550€ so this is two times the storage for little more than half the price, and they might be even cheaper nowadays).
If you're not sure if the T5 speeds will cut it for you, you can always look up speed tests on the internet and see how they compare to your own use cases. Sure, there are advantages to going with a 2TB internal drive, and if you have the disposable income to spare, then that can be a great choice in the long-term. But for all my use cases, the inconvenience/lower speed of external SSDs is far outweighed by their enormous price difference over the internal storage upgrades.