I went from the iPhone X to the iPhone 11 and am very happy. The iPhone 11 is faster, at normal viewing distances the LCD screen is a non-issue, the display is bigger, battery life is improved, the camera is significantly better, and Face ID is better than the iPhone X; all for $400 less expensive than the iPhone 11 Pro upgrade with 256 storage vs. 128 GB in iPhone 11. My only "concern" is the Intel modem in the iPhone 11 and ability to avoid dropping a call in fringe cell coverage areas, time will tell on that one. The iPhone X has the excellent Qualcomm modem.
I have Verizon service and so was late to the iPhone game, my first was the 4s. I went to the 5, 5s, 6+, 6s+, 7+, and the X, and the X was my least favorite phone due to the Face ID and need to avoid screen burn-in and have it turn off at 30 seconds. I knew the Xs did not fix the issue, so I never upgraded.