My primary concern is longevity as you kept your previous laptop for seven years (of which, I might add, you should be proud of!) and here's my thoughts with a little data:
When apple transitioned to Intel the last PPC based machine they sold rolled out of the factory in August 2006 (The Powermac G5 was replaced by the Mac Pro). Three years later, with the release of MacOS X 10.6 Snow Leopard, the Powermac G5 stopped receiving OS updates. It was possible you could have bought the machine and had it stop receiving updates before its AppleCare was out.
That cutover was pretty fast though. Apple did it in about eight months. They've said about two years for this one. With that date in mind I'll estimate we have about another year before Apple stops selling Intel Macs.
With these two data points I'll estimate that about four years from now Apple will stop releasing OS updates for Intel Macs. That puts a bit of a date on an Intel machine bought today.
Crunching the numbers further, you're getting about a 30% discount. Knock 30% off seven years and you get around four and a half. So with that large a discount the buy seems perfectly fine but you'll have to accept that you'll be buying a new machine in four years or so (to keep current with software).
I'll throw another wrench into these calculations: five years after the release of the first Intel based Macs apple stopped producing updates for them because they weren't 64-bit. I wouldn't be surprised if we see the same issue with the M1s. Not a bit bump (we'll be running 64-bit machines for a while) but some other serious change that Apple didn't quite plan for. The Core2 based Macs that came out the same year as the initial Core1 based Macs got another year and a half of updates.
With those couple data points no Mac you buy right now will get you seven years of longevity. Like I mentioned above, the Intel machine is fine if you don't mind replacing it in four years. If that's an issue, though, I'd wait for an M1X or M2 (or whatever they call it) based 16" MBP and buy that at full cost. The amortized cost of each will likely be about the same.