The iPad 7 will be good for notes, but with the A10 (A8 likely to be dropped next year) 5 years might be the point at which it no longer receives OS updates and apps gradually stop running on it. The Air 3 has the A12 so is the more future proof machine.
The only issue is the white spot, which has appeared on some Air 3 units.