When I first installed 3.1, the battery life on my 3GS was absolutely horrible. Typically, under 3.0.1, I'd have about 65-70% battery life left at the end of a day. Under 3.1 (with the exact same settings: Bluetooth & WiFi on, Fetch and Push OFF), I was getting 28-35% battery life left at the end of a day.
HOWEVER... I was having other problems under 3.1. Visual Voicemail stopped working and my 3G data service wasn't working properly. About 75% of the time, when I'd go to use 3G data, the phone acted like it wasn't connected to ANY data service, despite the fact that I had 4-5 bars of signal. If I reset the iPhone (hold down both home and power until I saw the Apple logo), then data would immediately start working. But, next time I went to use it same problem! I was reseting the phone multiple times per day!
Those problems prompted me to call AT&T. The service rep escalated me to level 2 where a very helpful gentlemen promptly asked me, point blank, if I had every jail broken my iPhone (NO!), or hacked the carrier settings to enable tethering. Oops... sheepishly, I admitted I had! He told me that is the source of the troubles. He said 3.1 doesn't play well with hacked iPhones (probably because AT&T and Apple want it that way). He then instructed me to reset the network settings, which didn't help (Voicemail was still dead). Next he had me do a restore from backup. That still didn't help. Finally, he told me the only thing that would work was a restore as a new iPhone and then manually reinstall all of my music/photos/apps and manually reset all of my preferred settings! This did not make me happy! But who was to blame besides myself?! I'm man enough to admit when I did something I shouldn't have and spend the better part of a day restoring the iPhone as a new phone.
When I was done, my iPhone is working better than before 3.1! It's seems snappier than even under 3.0! I have had ZERO problems with Voicemail. My data service ALWAYS works correctly and, to my "seat of the pants" measuring method, seems faster then ever. And, guess what?.... At the end of a day, I now have between 65-70% of battery life left!
Now, I'm not suggesting that everyone having reduced battery life post-3.1 has done any hacking on their iPhone. But, let's face it, there is a pretty high percentage of folks in these forums that HAVE hacked their iPhone. If you are one of them, and you installed 3.1 over the hack, you just might be having problems because of the hack.
Mark