I do not think this is a valid assumption because the battery life declines as the battery ages no matter the usage patterns and none of the various strategies to keep the battery as healthy as possible have ever been proven in a large sample size to actually work. Sure the 17 Pro might get you through the day a year longer than a 17 but then you spend hundreds more up front instead of getting a new battery for the 17 for 100 bucks.
And you might as well get as much out of the battery as you can since you know from the start that you're going to get a new one when the battery life inevitably declines to a point where it's bothering you.
Whatever made you choose the 17 that you seem to be happy with right now, you obviously had your reasons and I don't think you should throw that out the window and spent hundreds more so you can save on a cheaper battery replacement.
I rack up hundreds of charge cycles without a care in the world and after 2 years the battery is usually shot. Doesn't matter, I get a new one, and if I ever trade in the iPhone or sell it then I get that money back anyways and people tend to pay a bit more when they see the battery is a newer one with good health.
Obviously if money was never a factor and the excellent value of the 17 didn't actually matter then of course the 17 Pro has the better tech and better battery than the 17. And while you are at it you might as well replace it again in a year or two. Who needs battery swaps when you can get a brand new iPhone?
You could also get a small magnetic magsafe battery pack, I have the new small 5k Anker nano that has a bit more capacity than the new Apple iPhone Air battery pack and gets my iPhone from almost empty back to around 80%. This particular pack is thin enough and the magnets strong so it stays attached when i put the iPhone in my jeans pocket.
Even if I had the 17 Pro I'd still use that battery pack as it adds multiple hours of screen on time.