My current notetaking app is Notability for the vast majority of my notes. However I use Goodnotes5 for certain things (particularly reading pdf textbooks) as I find it a lot easier to highlight, make annotations, and navigate large pdf files in Goodnotes5. Both sync across very nicely between my devices (iPad, iPhone, Macs).
Since I upgraded to my iPad Pro a few months back I have tried out Evernote (my previous default), OneNote, Notability (which I used to use before going to Evernote), and Goodnotes5 (completely new to me). They are all good for different things so it really depends on your use case!
Evernote
Pros - good cross platform (Windows compatible - which is why I was using it), handles drawings/diagrams in line with text well, prints out notes nicely.
Cons - heavy use requires subscription, notes tend to refresh when I open the app
OneNote
Pros - good cross platform, infinite canvas
Cons - infinite canvas, typed notes need to go into textboxes which don't always align well
Notability
Pros - handles text and typing well (can type both with and without textboxes)
Cons - limited to Apple devices, doesn't deal well with page sizes, doesn't deal well with drawings/diagrams in line with text, folder organisation is limited
Goodnotes5
Pros - good folder organisation option, can set default page sizes, nice highlighting/markup options
Cons - does not handle text and typing well (can only use textboxes, no easy bulletpoints), limited to Apple devices
Ultimately I went with Notability for my notes because I type a lot and the ability to handle text well was important to me. The "limited to Apple devices" thing is no longer an issue now that all my devices are Apple (I held out for ages against switching to a Mac so this used to be a issue). I found some workarounds for the cons (page sizes, drawings/diagrams) so I can live with them for now. I really liked Evernote but didn't feel it was worth the cost of the subscription.