macOS C printf variable making new line using fgets

[Cabbit]

	// Get username
	printf("What was your name again? ");
	
	// Get username using fgets, this is how to do it without a security error
    fgets(name, 15, stdin);
	// End get username
	
	// The user hears someone calling their name, using variable called name
	printf("Mysterious Voice %s %s \n", name, name);

My expected output is "Mysterious Voice name name", my actual output is "Mysterious Voice name
name

"

Anyone know why and how to fix it. name is a char

 

[lee1210]

The newline is coming from the fgets. You can strip it after you read it, that should take care of it.

-Lee

 

[longofest]

...more precisely, it's coming from the user input. fgets() gives you everything the user inputs up to and including the \n. like lee said, strip it, and you're golden.

 

[Cabbit]

i fixed it as you suggested using

// Remove \n from name
	len = strlen(name);
	if( name[len-1] == '\n' )
		name[len-1] = 0;

I was using gets() before which did not have the same problem.

 

[ianray]

I was using gets() before which did not have the same problem.

Good move though

fgets() is safer than gets() because the former includes a buffer length.