Can I have your opinions?

Discussion in 'Web Design and Development' started by applefan69, Jan 24, 2008.

  1. applefan69 macrumors 6502a

    applefan69

    Joined:
    Oct 9, 2007
    Location:
    Medicine Hat
    #1
    Im an amateur php/mySQL coder. I've been working really hard on the site im about to present to you guys.

    http://216.45.112.6:8888/

    Its hosted off my own mac.. I turned my macbook into a mini personal server, because it didn't make sense to purchase hosting simply to practise and learn php and mySQL.

    What i'd like to know is what your coding guru's opinions on this are. I know its not the greatest site ever made, but I feel its pretty good considering just 3 days ago I hardly knew what mySQL was. So how would you rate this?

    What do I need to work on?
    What do you suggest I add to this site?
    Did you spot any bugs?

    If you guys dont want to register you can just login as:
    Username Tyson
    Password tyson69

    thanks to anyone who replies. :)
     
  2. SrWebDeveloper macrumors 68000

    SrWebDeveloper

    Joined:
    Dec 7, 2007
    Location:
    Alexandria, VA, USA
    #2
    Can't access -- You'll find that many people have firewalls within work or school LAN's that prevent access to port 8888 so your audience is alot smaller. Might want to try 8080 which more folks allow (not all), 81 (same situation) or 443 - an SSL port but open to most.

    -jim
     
  3. angelwatt Moderator emeritus

    angelwatt

    Joined:
    Aug 16, 2005
    Location:
    USA
    #3
    It's a very nice start. I've provided some tips and advice below. If you need any further explanations of anything here just let me know. Not sure how familiar you are with the terminology.

    • Move the Search box to above the navigation. People expect it higher up. May even want to move it into a corner of the header ... maybe.
    • The login form code is invalid. Place the form tag outside the ul tag. Also make sure to close tags, like the bold tag for User name.
    • Use a DOCTYPE (which is placed at the very top of the file. From the look of your code you should go with XHTML Transitional or Strict. Check this site for more details on DOCTYPES.
    • The button for the login form should get a name. Likely just an oversight.
    • For the login form, you should use the label tag around "Username" and "Password" as good practice, and not use the b tag as it is deprecated, use strong instead, for better yet use CSS to style those label tags with bold. (See example below)
    • The i tags are also deprecated so use em tags or CSS.
    • I used the provided login and it came to a screen that said I'd be redirected in 5 seconds, and it did try, but failed to go to the home page. Had to click on the link provided. Looks like it's caused by trying to add a head tag with a meta redirect inside the body tag, which is invalid code. Moving that meta tag to the real head tag should fix that.
    • I'd change the style for links in the side bar. Very hard to tell what is click-able. Text is kind of small too.

    Example for form labels:
    HTML:
    <label for="username">Username:</label>
    <input type="text" name="username" />
     
  4. ChicoWeb macrumors 65816

    ChicoWeb

    Joined:
    Aug 16, 2004
    Location:
    California
    #4
    Design Wise: It's not bad. Though everything seems pretty squished. Might want to look into some line-heights and paddings. Looks Kubrick-esk.
     
  5. tominated macrumors 68000

    tominated

    Joined:
    Jul 7, 2006
    Location:
    Queensland, Australia
    #5
    that's because it is a template ;)
     
  6. ChicoWeb macrumors 65816

    ChicoWeb

    Joined:
    Aug 16, 2004
    Location:
    California
    #7
    Well, that would explain it then! :)
     
  7. applefan69 thread starter macrumors 6502a

    applefan69

    Joined:
    Oct 9, 2007
    Location:
    Medicine Hat
    #8
    Thank you for all the suggestions, i noticed a thing you mentioned alot is to not use b or i tags... I guess thats an issue I generally have when coding, because i learned HTML a long time ago (before XHTML) and i've never really taken the time to go back and learn all the new stuff... I think I'll do that right now thouhg. :)'

    Also thank you, i noticed the redirection wasn't working, it was getting annoying, but i think you explained why... Once again i appreciate the help your giving... I plan to make this into a blog of some sort, mostly because I want to challenge my coding skills.

    To everyone which the page did not load for, that is because the site is hosted off my own macbook (cause it's jsut a few simple pages, nothing my mac can't handle) But if the site didn't load for you, it was probably because my macbook was turned off... i dont leave it on overnight due to people having overheating issues with macbooks. When I have this site actually functioning like a REAL site, i'll move it onto payed hosting.
     

Share This Page