upgrading to ios8 will cost you a nice chunk of space. unless you need ios8 features such as to run apps, i wouldnt upgrade if you're short on storage, etc.
much of ios8 is continuity, handoff and of course security updates
For me, it was worth it despite a slight drop in speed because of the features that work alongside my mac and iphone