Your analogies aren't actually considering the whole situation. We often invite people into our homes. An app that you choose to install is like a maid or handyman that you hire to perform a job for you. The App Store is the referral service that you trust to verify the credentials of the service provider. Do you think that most people follow the maid around the house to make sure they don't steal anything?
Good comeback analogy! But let's face it every analogy has its flaws. Given the number of apps users tend to have on their phones these days, your analogy would require maids and handymen coming in and out of the house all day everyday. In a more realistic scenario, where the cleaner comes in by herself on a certain day, you may not follow her around the house, but if your computer goes missing after she was in, you'd have a pretty good idea who did it! Not the same with apps on your phone secretly doing evil things with your private data. In most cases you would have absolutely no way of knowing that anything had happened. None. A flashlight app could be siphoning off your private data for months, even years, and you'd be completely clueless.
And, yet, they haven't cared for the last couple decades.
You're confusing apathy with ignorance.
The obvious answer here is - I don't know all the situations where this would occur. That's the problem. Most consumers can't make an informed decision. All a malicious developer would need to do is design their app to give a spurious reason to access the photo library.
Now hang on I'm not asking 'most consumers'I'm asking you. You're the one insisting how inconvenient this is going to be yet you can't name even one situation where you would prefer that an app secretly access your photos? Not even one? I think I'm getting ready to rest my case here.
So your solution would protect us from all those non-photo related apps that want to steal our photos, but do nothing to prevent the photo-related apps from stealing out photos.
If there really is no practical way for iOS to tell if that photo is being sent somewhere, then yes. It's like the lock on your door which you willingly open for certain visitors. Are there still risks? Sure. But at least you've minimised the risk by greatly limiting the number of apps with access to the photo library. Not only that, but in most cases (see Tinmania's explanation of the photo picker) the user has only granted access to a particular image. Going back to your earlier example of a GPS app with custom backgroundsthe user might choose a photo of their dog Fluffy as the background image, but that shouldn't give the app access to the photos they took in the bedroom the night before!
The lock is not what's in question. Developers only have access if you invite them in the house. The most valuable items (location data, phone access, messaging access) are in the safe.
Woah there Why do you see location data as inherently more valuable than photos, videos, address book contacts, notes and other potentially sensitive private data? You could potentially ruin someone's life with the kind of data we're talking about.
How do you expect the system to know that apps are secretly taking an action. Magic?
Isn't that how all Apple products work?
Likely Apple will come up with some ideas, but they will be limited. For instance, they could require apps register for resource use such as the photo library and networking. By definition, a photo editing app would require access to the library to be useful. If it allows you to send postcards, then it requires networking. As the user purchasing that app, you understand its purpose and resource access. What you and Apple can't tell, is if an app is being malicious.
In each of the examples you mention, the user would have to manually choose an image for the app to use. That gives the user explicit knowledge about which photos an app has access to, if not complete knowledge about what's being done with them. This is still a huge improvement regarding a user's privacy over what you and BaldiMac seem to be proposing, where an app can access any image it wants to anytime it wants to. Madness if you ask me.
If you put too many warnings in, people will be annoyed, and it causes a poorer user experience. Windows Vista proved it.
Indeed Windows Vista proved it. Even XP, which I still run on an old PC here, annoys the heck out of me. But as already discussed, there is no need to generate a warning when the user is asked to choose a photo. Permission is an implicit part of that process. So let me ask you the same question I asked BaldiMac: 'under which conditions would an app need to access your photos without you telling it to? To put it another way, under which conditions would you be happy for an app to secretly access your photos?'