It depends on what improvements you are looking for. If camera and battery are your main concern, then the iPhone 11 will be an upgrade. If you want OLED and a smaller size then the 2019 Xr is not an upgrade. I have an iPhone X that is only a few months old. So I won’t be upgrading until 2020.
Camera and battery are important. As for the screen I just want what works. OLED on X is good except for when dimming in lower light then am not happy with it. If IPhone 11 is a good screen of similar fine with me. I don’t need OLED for the sake of it. Only if a functional benefit.
I actually went from an iPhone X to the iPhone 11. Preliminarily, I really like this phone coming from the X. The LCD screen is a non-issue for me, it looks great. Better battery life, larger screen, larger display, faster, better Face ID, better keyboard, & better camera. Had iPhones: 4s, 5, 5s, 6+, 6s+, 7+ and X; liked the X the least [Face ID--which the Xs did not fix] and the jet black 7+ the most. To me, the iPhone 11 is what the iPhone X should have been, and Apple got back on track with their iPhones. Very happy and for the price I paid, I might be back on track for yearly upgrades