I've seen some Youtube tests comparing SSD speed against the previous generation. Most reviewers are only getting one model. I think it will be difficult to find a comparison between different size SSD drives of the 2018 models.
My guess is that you wouldn't see a speed difference.
In general speeds of larger SSDs then to be slightly faster since they can do more transfers in parallel. There are plenty of page and videos that go over sizes versus performance for Samsung and manufacturers SSDs. So I would expect slight increases in performance for the larger SSDs on the MBP 2018. But since the new drives are very fast this may not result in any perceivable decrease in the time it takes to do tasks.
With how fast these SSD's are you wouldn't notice any real world difference anyways. Certainly not enough to throw another $200 at since size is not an issue.
Was also debating between 256 / 512 but decided to stick with 256 I doubt you see any difference MAYBE if you upgrade to a 1tb+ but not worth the cost.