Upgrading is just fine with OS X, you won't see the performance suffer from this.
But a new OS is always a good excuse for a clean install, mostly to uninstall old programs that you don't use anymore, free some HD space, etc.
And it also feels nice to have a just as new system.🙂