Not necessarily. Apple has a habit of selling brand new phones from prior years at a lower price point each subsequent year. So, next year, any unsold Xr’s will go down in price and you might find them affordable. And if not, then wait a year. The Xr will still be around, and even lower in price. Just as the iPhone 7 is still around and lower in price this year than it was last year.
So, maybe when you finally do need a new phone (say two years from now) you might actually be able to get an “X” model that has come down dramatically in price. Or, at the very least, you might be able to buy a used/refurbished one.
Apple seems to really want to transition customers to Face ID, AR, etc. The Xr (still out of reach for a lot of people) might be the best they can do for now, but I suspect they’ll try harder, each year, to offer more and more affordable versions and so get everyone on board with this technology.