macOS running two applescripts together

[hehe299792458]

I'm trying to run these two scripts in one file in AppleScript:

global UserName
global ServerName
global passwd

on ActivateX11()
    tell application "Terminal"
        activate
    end tell
end ActivateX11

on ActivateTerminal()
    set ScriptCommand to "ssh -X -N -D 8080 " & UserName & "@" & ServerName
    tell application "Terminal"
        activate
        do script ScriptCommand --  Establish the SSH connection
        delay 3 -- Wait 3 seconds for the password prompt to appear
        do script passwd in window 1
    end tell
end ActivateTerminal

on run
    set ServerName to "xxx" --  The name of the server to connect to
    set UserName to "yyy" --  The user to connect as
    set passwd to "zzz" --  The password for the user
    ActivateX11()
    ActivateTerminal()
end run


tell application "Finder"
    activate
end tell

tell application "System Events"
    if UI elements enabled then
        click menu item "SSH" of menu "Location" of menu item "Location" of menu "Apple" of menu bar 1 of process "Finder"
    else
        tell application "System Preferences"
            activate
            set current pane to pane "com.apple.preference.universalaccess"
            display dialog "UI element scripting is not enabled. Check \"Enable access for assistive devices\""
        end tell
    end if
end tell

But I get the following error message:

The run handler is specified more than once, or there were top-level commands in addition to the run handler.

What can I do to fix this?

 

[kryten2]

What have you tried?

Info : https://developer.apple.com/library...tml#//apple_ref/doc/uid/TP40000983-CH206-SW15

 

[hehe299792458]

What have you tried?

Info : https://developer.apple.com/library...tml#//apple_ref/doc/uid/TP40000983-CH206-SW15

Thanks for the link. I'm not very familiar with coding. so I dont think I understood everything in the article. But as far as I can tell, the previous run handlers were closed before the second script. I thought those should prevent these errors from occuring

 

[superscape]

as far as I can tell, the previous run handlers were closed before the second script. I thought those should prevent these errors from occuring

Yep, you're right. The run handlers are closed. It's the second part of the error message you need to be looking at:

...or there were top-level commands in addition to the run handler

I expect that all the stuff after the "end run" line probably belongs one of your handlers. Or perhaps in a handler of its own, depending on how you expect your script to behave.

 

[kryten2]

Did you try leaving out the explicit run handler?