The best phones ever made doesn't really matter when the prices hit the level they have hit. I can easily afford iPhones at the current price, but I'd rather spend that large amount of money on something that gives more back. My iPhone 7 can still easily do everything I want out of a phone. I just upgraded from a 2017 MBP 2.9 to a 2018 MBP Vega 20 fully maxed out except the SSD, because the upgrade will make a big difference to my work, video editing, photo editing, gaming, studies, development, and so on. I'm not reluctant at spending money if the return is worth it.
My phone on the other hand... Is just a phone. It's a time waster device for whenever I just need to browse something to keep myself busy. And for that purpose any phone these days gets the job done easily. Just got a new battery in the 7 as well, and I foresee keeping it until it falls apart completely. The day the new iPhone gives something really worth it back, then I'll consider an upgrade. At this stage I would upgrade my computer, Nintendo Switch, PS4, TV, router, camera, lenses, and mostly everything else before I would upgrade my phone.
Some people "live on their phone" so I understand they would want to upgrade.