There's no real right or wrong. Apple's put a huge amount of engineering into making machines that are able to run continuously for weeks or months on end, with very low power consumption during sleep. It doesn't mean we're obligated to take advantage of that capability, but it's there if you want it.
I prefer to sleep my Macs. While waiting for an SSD- or Fusion-based Mac to boot isn't the worst thing in the world, when I sit down to work, I want to get right to work. I can go a few weeks or more between the need to reboot on my "newer" (late 2013) iMacs. My poor, old early 2008 iMac with its original spinner is just a bit too long in the tooth to stay up until all hours ;-), but since it also takes by far the longest to reboot (and wake from sleep, for that matter), the last thing I want to do is shut down and reboot daily.
My iPhone, iPad, and Watch go far, far longer without a restart. They tend to reinforce my confidence in the ability of Apple's OSes and hardware to run on nothing more than a good night's sleep.
Now, 30 years ago was a different story. PC hardware and OSes were not what they are today. I think it's OK to change our habits in the face of changing circumstances..