I think the question is less about if more about when.
One of the limitations of the Apple silicon generation is that it can't natively run x86 apps. At present, there are going to be plenty of users that either want or need that functionality still - be it for work or hobbies.
So until the majority of users have found ways to switch over to ARM, I think the demand for Intel Macs will always be around to a degree. But since the performance gap on these machines is now closing tighter than ever, less people may have a reason to purchase a second-hand MacBook Pro when the Air is so powerful.