Become a MacRumors Supporter for $50/year with no ads, ability to filter front page stories, and private forums.
As I said above, I don't plan on reselling this since I'm a Sprint customer, and I'm content with waiting for 2 years until the next upgrade. Considering that the 3GS is over 2 years old and it's still capable of doing everything (it can run iOS 5, yes?), I'm not really concerned. I'm fine with getting the entry-level iPhone every 2 years.

I'll take that $100 and invest that into the higher-storage-model iPad 3 when that launches, as that will hopefully last me longer than 2 years (going on 7 with my iBook G4 right now and that runs wonderfully still)

The 16GB should be fine. That's what I'm getting. I will just do nightly transfers to my laptop to off load all the pictures and video taking up space.
 
I had a 16GB 3G and went with a 32GB 4S this time around basically due to he fact that I know I would be shooting a lot of video with the phone. I wanted to be able to have the ability to shoot a week's worth of vacation video (HD) on the phone if I wanted too, so I figured doubling the storage size was a good move.
 
I had a 16GB 3G and went with a 32GB 4S this time around basically due to he fact that I know I would be shooting a lot of video with the phone. I wanted to be able to have the ability to shoot a week's worth of vacation video (HD) on the phone if I wanted too, so I figured doubling the storage size was a good move.

Yes, if money allows by all means the more memory the better.

I am also getting an iPad 3. I will take the savings by getting the 16GB iPhone 4S instead of the 32GB and put it towards the mid-range iPad 3 . I feel a higher capacity iPad would be more beneficial to me.
 
This really is kind of a tough question because once you decide you have to live with it (short of going through the hassle of reselling, etc.). That said, I'll try to chime in here to help.

First, I WOULDN'T get a 16GB UNLESS you a.) really can't afford more and/or b.) you are absolutely sure you won't need more space. Even with this, I caution you regarding "b" because there may come a day when all of a sudden you need more space (due to app, video, pics, music, movies) and now it's just too late.

Next, the 32GB. I'd probably go with this one (to answer your question). It has a decent amount of space and doesn't cost so much that you'll get the feeling you paid for a bunch of space you don't need.

Last, the 64GB. If price isn't an object, this is the one to get. It has better resale value later and with the large video file size of the 4S, it will give you lots of room. If you like to carry a lot of movies, take lots of videos and photos, this may be the one for you. remember, iCloud can handle the music issue regarding space. I use iTunes match and as a result I have all my music available but very little on the phone at any give time taking up space. So, if you want a larger phone for music you may not necessarily have to get the 64GB if you are OK with using iCloud.

Hope this helps!
 
Register on MacRumors! This sidebar will go away, and you'll see fewer ads.