FYI
A lot of people set their phones up this way and this will cause more and more problems as the iOS software progresses with iCloud backups and application integration.
I would suggest getting different iCloud identity’s ASAP.
Create a family iCloud account for purchase sharing amongst different ids.