I decided to move on from my XS max to a 12... but I was ready for a smaller phone and couldn’t resist the blue color. The fact that the 12 has OLED made it an easier call because the extra features of the Pro didn’t grab me. Otherwise I wouldn’t have switched, though I am interested to try nightmode.
If you don’t feel that compelled to move on I would wait to see what next year has to offer.