I'll be keeping my iPhone X for as long as it works well.
But if I had to change when the new iPhones come out, I don't know what I'd do. It has taken me a long time to adapt to the size of iPhone X from my previous 5s. And I still resent the downsides sometimes: it's too big to fit in my jeans so I have to bring a bag just for the iPhone, it's heavy, and I can't use it with one hand. But I've recently started to appreciate some advantages of a bigger screen size recently doing things that would have been very uncomfortable on the 5s: editing a video in Lumafusion, working on a spreadsheet in Numbers, and updating a document in Pages.
Probably it's a good thing that I don't have to choose a new phone because I really wouldn't know what to do.