Become a MacRumors Supporter for $50/year with no ads, ability to filter front page stories, and private forums.
[...]

Thats not how encryption works, encryption means no one has access to it except the person with the password. If they can access it, you might as well leave it unencrypted same results.
I disagree. Your data is accessible by the government under some legal due process, but not to hackers who could somehow penetrate icloud and download information...as Apple has the keys.
You can do all this without data collection. I can take a picture without them knowing about it, I can store my files in iCloud and its encrypted(In fact Proton is releasing ProtonDrive very soon that does this exactly). You can use digital assistant without storing your voice recordings (https://mycroft.ai). Apple choose to use a less private way.
You are advocating Apple dumbing down their ecosystem to some lowest common denominator. That's not how Apple works the ecosystem, which is to provide a level of continuity to it's users across multiple devices. Seems like lessons learned from Google and Amazon indicate more voice samples to it's machine learning algorithms are better. Apple takes a more restrictive approach and that is what seems, at times, to put it behind the competition.
 
Register on MacRumors! This sidebar will go away, and you'll see fewer ads.