Broken images in comments

Discussion in 'Site and Forum Feedback' started by craig.francis, Aug 4, 2017.

  1. craig.francis macrumors newbie

    Joined:
    Apr 3, 2016
    #1
    When someone posts an image in a comment, they're being replaced with a small icon of an image with a red cross over it:

    https://forums.macrumors.com/proxy.php?image=404

    As shown at:

    https://www.macrumors.com/2017/08/03/apple-bluetooth-low-energy-audio-cochlear-iphone/#comments

    https://forums.macrumors.com/thread...plant-iphone-accessory.2059852/#post-24861933

    This is probably due to the MacRumors website moving over to HTTPS, and it using "proxy.php" to get that image (to avoid mixed content warnings, privacy concerns, too large or malicious images, and not wanting to DDOS the source server).

    But it doesn't seem to be working.

    It would be nice if the image could also link back to the source. So if the image didn't load, someone could click on it, and request it directly... in this case, that would be:

    https://media.treehugger.com/assets/images/2011/10/zinc-air-battery-chart-01.png
     
  2. arn macrumors god

    arn

    Staff Member

    Joined:
    Apr 9, 2001
  3. arn macrumors god

    arn

    Staff Member

    Joined:
    Apr 9, 2001
    #3
    hmm... wasn't working and now it is. Are you seeing this with other images too?

    arn
     
  4. timd.mackey macrumors member

    Joined:
    Jun 8, 2010
    #4
    @arn This happens to me almost all the time. Usually I'm just looking at the top comments on articles, but when I browse the forums on occasion I see this too sometimes. Any clue what causes this?

    Currently seeing this issue here: https://forums.macrumors.com/thread...luded-in-the-october-30-event-invites.2149571. The images were working for me about an hour ago, but now they're broken in both the forum and the article page.

    [​IMG]
    (url in case this image embed somehow get's broken ;): https://imgur.com/gallery/GZ9DNZC)

    EDIT: And now, of course, it's started working again... :confused:

    [​IMG]
    (https://imgur.com/gallery/oygGGT9)
     
  5. arn macrumors god

    arn

    Staff Member

    Joined:
    Apr 9, 2001
    #5
    My guess in these situations is that imgur prevents hot linking?

    arn
     
  6. D.T. macrumors G3

    D.T.

    Joined:
    Sep 15, 2011
    Location:
    Vilano Beach, FL
    #6
    Those images aren't directly linked, they're going through a proxy function on the forum side, here's the URL for those images:

    Code:
    https://forums.macrumors.com/proxy.php?image=https%3A%2F%2Fi.imgur.com%2FCc6gGar.jpg&hash=27542767f4c9f0143f967a1bf56d679d
    So if there's a failure on the forum side to fetch the image data, the markup doesn't get a valid image, and it throws up the X as a placeholder.

    Now that doesn't mean that Imgur is preventing the image from being fetched, it would also break it - but I just wanted to point out there's a potential failure point on the forum side as well.
    --- Post Merged, Oct 24, 2018 ---
    [​IMG]
    --- Post Merged, Oct 24, 2018 ---
    Sorry, that's sort of big :D but it's the same thing I simply added a URL for an image via the message UI, and it generates that proxy code (vs. a direct link).
     

Share This Page