I don't understand so many negative comments: it is not mandatory to use this feature!
Personally I don't care about most digital data (SMS, notes, reminders...) but the photos are really important.
In the past, before smartphones, most people had a camera. And a lot of family's printed photos or slides, that will remain in a drawer and in most cases they are never lost (except if the house burning...), even 50 years later, even if some family members die.
But now most people DONT have camera, and all family photos are taken with a smartphone. In some cases, most of them with the SAME smartphone (because one family member has the one with the best camera). If they are lost, all is lost for husband/wife...children that will never have a photo of childhood.
And in my opinion, it is ALREADY a problem even if you don't die: most of people don't take care about password, don't take care about backup, don't use well cloud services. I suspect there is already a lot of people (technologically incompetent) that are crying 'This **** of technology! I was better in the past, with printed photos!' because they have lost all lifetime photos!
Unfortunately, technology is your best friend if you learn to use it well, but it is your worst enemy if you don't spend some time to master it...
BTW there are also other question that I had... what about not paying anymore the subscription (bank account blocked after death for e.g.) ? How many time to retrieve the data, before Apple delete the account and data?
Me I planned a different thing for my death: a safe-deposit box in my bank, with some detailed instruction, also some password to retrieve my data etc... but usually it could take month for heirs to access it, especially if they don't consider it a first priority (a notary is needed in Europe to open it, to estimate value inside to pay taxes, to identify heirs that have the right...) ... I wondering if meanwhile some paid account (no more payed...) and free too (that could be deleted because not used) could be lost forever anyway...