If your have a functional phone right now, then I’d wait since your so close to next release.
If your without a phone, then there’s no feeling remorse’s buying an amazingly top of the line “over built” X now.
The newer phones won’t be as high priced while cutting manufacturing costs. So if you don’t need a phone now you’ll be paying less if you wait.
The only difference is some parts won’t be as “premium” in my own opinion, like a plastic SIMS holder rather than a durable metal one like in the X now.
Other ways Apple will save will be going with LG displays over Samsung’s at lower cost per unit.
The X is the new standard moving forward so it won’t be “dated” like the 8’s and below are with a home button.