Your first sentence is incorrect. Apple has never been known to open personal photos uploaded to iCloud, and it has been known (repeatedly) to resist government requests for such photos. You might be thinking of the recent news articles about Apple's proposed new hash-matching system, but that system has not yet been implemented and, from what we know, targets only those photos that match hashes associated with known child pornography. The e-mail I responded to was about uploading nude personal photos generally, and called it the "most moronic" thing a person could do on a computer. I simply disagree. iCloud is intended for photos, including personal photos.
Although your second sentence is correct, it is something many people address by using a secure password, two-factor authentication, etc. That obviously didn't work here, but these are the measures that are generally used to protect personal documents and information stored remotely.
As to your view that "there is zero reasons to take nude pictures of yourself and store them" in the cloud, I would suggest that the reasons are the same reasons people would use to store any photos in the cloud -- convenience being the main one. Simply put, people who take photos tend to want easy access to those photos. Perhaps your real point wasn't that "there is zero reasons," since there obviously are reasons, but rather that those reasons are outweighed by countervailing factors?
