Ok. At least now we know both machines are named uniquely, cache cleared, DHCP working, Sharing enabled, and we know that MACPRO-2 can ping MACPRO-1.
#1 - Confirm you can open Safari or any browser on MACPRO-2 and you can access the Internet. Can you open google.com or apple.com? I'll assume yes that MACPRO-2 can access the Internet.
#2 - You don't use a VPN on MACPRO-2 do you? If you do, make sure to turn it off or disable it. I probably should have asked this days ago but VPN never came up in our discussion. I'll assume no that MACPRO-2 does not have VPN.
#3 - Open Terminal on MACPRO-2. This command will list the contents of your hosts file.
cat /etc/hosts
Screenshot your hosts file and post it. There shouldn't be any odd entries. It should look like this.
#4 - Delete the Finder preferences file on MACPRO-2. The easiest way is to use the Terminal. Close Finder. Open Terminal. Issue these two commands one at a time. The second command will ask for your password just like before. It won't show any characters.
cd /Users/RichLeffler/Library/Preferences
sudo rm com.apple.finder.plist
This will delete the Finder preferences file. Then open Finder and confirm all the preferences are selected/active.
If MACPRO-1 still doesn't show up in MACPRO-2's Finder, let's try to at least connect manually.
Open Finder. Press COMMAND+K to open the Connect pop-up. Type
smb://MACPRO-1.local in the top field then click Connect. If it works, you will be presented with "You are attempting to connect to the server "MACPRO-1.local" Click Connect to Continue. After you click connect, it will ask you for username and password. Select
Connect As: Registered User enter the username and password you use to login to MACPRO-1. If that is successful, you should be presented with a list of volumes to mount. You can mount more than one by holding down the Control key, or just select
RichLeffler to mount the home directory, or select
HD 1 through
HD 4 to mount all the drives from MACPRO-1.
If this manual connection process fails and you cannot successfully connect to MACPRO-1 from MACPRO-2 and you cannot mount any drives, there may be a configuration issue on the router (blocking MACPRO-2 from seeing local shares for some reason) or perhaps something with El Cap no longer works. I'll have to do some Internet searching to see if El Cap exhibits any weirdness with regard to local network shares with newer OS X/macOS versions.
Do you have another Mac you can connect to the router if MACPRO-2 still cannot see or connect to MACPRO-1? Would be interesting to see if another Mojave or newer device can see MACPRO-1 connected to the same router.