I think much of the contention I see on the forum is whether or not Vision Pro will do well, not necessarily if Apple Vision/visionOS as a whole will do well. Vision Pro may struggle initially, sure, but in the long term I believe in the always present AR platform that you wear all day in a normal looking pair of glasses.
I think one of the big use cases for the future AR version is essentially just applying the concept of watchOS complications/iOS widgets but projected onto the real world, statically placed in contextual areas of your life: your desk with reminders floating in the background, cooking timers floating above the stovetop, transit times floating about the subway platform, etc. This is clearly the direction Apple will go because look at the headline feature of Sonoma: widgets on the desktop. I'm finding them to be way more useful on macOS than ever before, hell they're even more useful than on iPhone.
The problem right now is Vision Pro's bulk necessitates a sit down, at home dedicated session with the device rather than enabling a "just in time widget info" experience like Google Glass tried to do. So many of the app use cases and demos are centered around a "floating iPad" experience with someone on a coach or at a desk. I think the real "aha" moment comes when people realize these devices can provide the right information, at the right time as you conduct your every day life -- but again that's not possible with Vision Pro, only a future version "Vision Air" or something.
In the long term, once the entire product line has been unveiled and has time to mature, I suspect Vision Pro will be the flagship device for dedicated immersive VR experiences and a different product (Vision Air or whatever) will be the flagship for AR experiences. A normal looking pair of glasses can never achieve the level of immersion that goggles can because they don't block the surrounding world.
Vision Air will be the iPhone, designed with the sole purpose of being the best possible always on AR Experience.
Vision Pro will be the Mac, designed with the primary purpose of being an at home/at work powerful device that can immerse you in a virtual space.
Maybe an entry level device, Vision, serves as a middle ground, kind of like iPad.