My choice was between the 11 Pro, 12, and 12 Pro. The 11 Pro was a non-factor as it was only $100 less for 64gb. I can still live with 64gb, but since I plan on keeping this phone for at least a couple of years, 128gb was more attractive. So for $100 more I get 128gb of memory, and then all of the other improvements of the 12 Pro. I know battery life is less than the 11 Pro, but it's not like battery life is bad, at all. It's still better than any other iPhone prior to the 11 line.
Then it came down to the 12 or 12 Pro. I personally went with the 12 Pro because I had a Xs before, and I know it's not for everybody, but I really enjoy having a telephoto lens (it comes in pretty handy with kids' sporting events, band, etc etc). Some of the best photos I got on the Xs were portrait photos in good lighting as well, and I feel like the portrait shots have a more natural feel when using an actual telephoto lens vs a phone that doesn't have one. If there was a more drastic price difference between the 12 (at 128gb) and 12 pro, I might've considered going without the telephoto lens. But there's not, especially when spread out over a few years.
If it wasn't for the telephoto lens, I likely would've gone with the 12, as I kind of like that blue color and the lighter weight. I still might be tempted by the mini... those specs in that small of a package (something I still like) are going to be hard to pass up, but I have a feeling battery life is going to be weak, at best.