These threads show up around this time every year. No one knows how Apple is going to price these phones, so that is all speculation. Also, no one knows what new features have not been leaked, both hardware and software-wise.
Once we have actual information from Apple, then we can judge if the new phones are worth the upgrade.
I was going to skip the 11 Pro Max, but the bigger battery and better camera system were worth the upgrade to me. Feel like I have gotten my money's worth on that one. YMMV.
I had the 6s+ and 11 Pro Max was worth it for OLED and the great battery.