I tried to keep my original X for a 3rd year but the battery had degraded to 85% max capacity and would not last longer than 6 hours at a time. It was not going to hold up as a daily driver for a 3rd year. And I usually upgrade at 2 years anyway.
So I traded in my X toward the 11 Pro Max while I could get the $400 trade in value for it. Going from the X to the 11 Pro Max got me a bigger screen/device, better battery, much faster system, improved cameras, much better Face ID, faster downloads. Yes 3D Touch is no more, but Apple crippled 3D Touch functionality on the X anyway with iOS 13. Haptic Touch works about 85%-90% similarly IMO.
I really deliberated about trying to make the X work for a 3rd year and waiting for the 2020 iPhone. But I did not feel that my X would have held up. And the way I see it, if the 11 Pro is the final iteration of the design that was started with the X, then I feel like it is certainly polished. And who knows what to expect from the 2020 iPhone in terms of design/features with all the rumors.