I went with a 256 GB XS Max and couldn't be happier coming from a 256GB X.
I went with the same from a 128gb SE and while the SE was fast, i'm extremely happy with the performance of such a large phone with that screen on IOS 12 it for me will be more than enough future proof to last the next 2-3 years. I'm extremely happy i bought the Max