Crap in your opinion, a lot of people are still buying the MacBook Pro's regardless of whether you like them or not, what you have to think about is that you only ever see on these forums when people have a problem/complain, you rarely hear when people are happy/content. Overall the MacBook Pro's have been selling well for Apple.
As for Ming-Chi Kuo he is very reliable when it comes to Apple, no not everything is always 100% accurate but he's certainly the most reliable out there.
https://appleinsider.com/articles/1...-industry-estimates-defeat-contracting-market
"During a recent
earnings call, CEO Tim Cook revealed that Apple's Mac division set a new all-time revenue record of $25.8 billion for fiscal 2017. Apple sold 5.4 million Macs during the September quarter, up 10 percent over last year, and gained significant market share as the global market contracted by one percent, according to IDC's latest estimate.
The performance was reportedly fueled by big demand for the MacBook Pro, said Cook, and Mac revenue grew 25 percent to a new September quarter record."
https://www.macrumors.com/2017/11/15/q3-2017-macbook-sales-increase-again/