Honestly, they’re decent computers, although they do have some issues. Fan noise in the higher tier models, the keyboard, lack of ports. The one thing I’m worried about right now isn’t the hardware now. It’s the software. Apple clearly hasn’t been putting a lot of resources in developing Mac OS for a few years now. I have the feeling that Apple is sneakily getting rid of OS X and will drop a hybrid OS on us as soon as they’re announcing their move to ARM. I don’t think the Pro devices will be moved to that any time soon, but overall OS X in its current form is on its way out. If you want a computer that lasts you several years, I’m not sure the Mac platform is overall a good choice at the moment.
That said: I’ll enjoy the heck out of my Apple devices until Apple will inevitably force me to switch to another platform. And yeah, I’d buy the 2018 MacBook Pro. The next version will just be a computer as well and won’t miraculously change everything over night. And the stupid butterfly keyboard is very likely here to stay.